vimeo / VIMNetworking

The Vimeo iOS SDK
MIT License
58 stars 25 forks source link

VIM-3829: Adds delay to error call in VIMRequestOperationManager #185

Closed cjlarsen closed 8 years ago

cjlarsen commented 8 years ago

Ticket

https://vimean.atlassian.net/browse/VIM-3829

Ticket Summary

Alert for No Internet Connection appears while still connecting. First detected while uploading, but reproducible without uploading a video.

Implementation Summary

Adds a delay to the error display and checks reachability again before dispatching it.

How to Test

  1. Go to 'Me' tab
  2. Turn off network (turn on airplane mode)
  3. Turn on network (turn off airplane mode)

previously an alert appeared, it no longer does.

cjlarsen commented 8 years ago

@huebnerob We talked about this last week, ready for review. Thanks!