vimeo / VIMNetworking

The Vimeo iOS SDK
MIT License
58 stars 25 forks source link

VIM-4015: Make VimeoUpload Consumable as a Cocoapod #186

Closed alfiehanssen closed 8 years ago

alfiehanssen commented 8 years ago

Ticket

Required for Vimeans only VIM-4015

Ticket Summary

Make VimeoUpload consumable as a pod.

Implementation Summary

Continuing to run into compatibility issues with pods. VIMNetworking currently depends on VIMObjectMapper as a pod. And it uses #import "filename.h" for all object mapper source imports. But when VIMNetworking is included using use_frameworks! these import statements break the build because they aren't module imports. But we can't use module imports because they'll break the VImeo-iOS app where it's not consumed as a pod (because we support iOS7). So a solution is to move the object mapper source files into VIMNetworking so that the import statements work without a problem when included as a submodule and when included as a pod with or without use_frameworks.

How to Test

Test that the project builds. Test that VimeoUpload example projects build (companion PR coming soon).

ghking commented 8 years ago

:tada: