vinceliuice / Mojave-gtk-theme

Mojave is a macos Mojave like theme for GTK 3, GTK 2 and Gnome-Shell
GNU General Public License v3.0
1.5k stars 243 forks source link

Fix bg color for popup menu (light themes) #223

Closed xeyownt closed 1 year ago

xeyownt commented 2 years ago

Hello,

I've noticed that the background color of popup menu for the light themes are very dark (seems similar to the dark themes one), but the font color is also dark, making the whole very hard to read.

This is happening at least on Debian 12, Gnome 42 (I tried on a virgin account, with only the theme installed globally).

I propose to fix this with an additional background-color property in gnome-shell.css. The only issue remaining is when the mouse hover away from the selection, the selection becomes very dark again. I don't know how that can be fixed, but it is really a minor issue.

The fix contains many changes, but these were actually generated with the following sed scripts (we go get the background-color property from #panel, then copy it back to popup-menu-content).

sed -nri '
:A; p; /^#panel \{/{ :a; n; /background-color/{h; b B}; p; b a }; n; b A;
:B; p; /popup-menu-content \{/{ :b; n; /font-weight/{p; g; b C}; p; b b }; n; b B;
:C; p; n; b C;
' *.css
xeyownt commented 2 years ago

The before / after snapshots:

before after