vincent-maillou / qttools

Quantum Transport Algorithms Toolbox
GNU General Public License v3.0
5 stars 1 forks source link

Need DSBSparse diag_like constructor with densify_diag=True attribute #33

Open vincent-maillou opened 2 months ago

vincent-maillou commented 2 months ago

To run RGF without issue, we need to overcome the problem caused by the sparse storage of the diagonal (expected dense) blocks. This lead to numerical inaccuracy in the current implementation of DSBSparse.

vetschn commented 3 weeks ago

@vincent-maillou I forgot if we already discussed this irl, do you think this is addressed sufficiently by the densify_blocks parameter in the from_sparray constructor? It gives correct results in practice but may be not the nicest solution...