vincent-maillou / qttools

Quantum Transport Algorithms Toolbox
GNU General Public License v3.0
5 stars 1 forks source link

ltranspose does not actually return a copy #62

Open awinka opened 1 day ago

awinka commented 1 day ago

In the ltranspose method, there is a boolean parameter called copy. See below reference:

https://github.com/vincent-maillou/qttools/blob/3fac381befe9470d5fd45e268120cf097465e0dd/src/qttools/datastructures/dsbcoo.py#L420-L484

If copy is set to True, the method is supposed to return the transposed matrix. However, in the current implementation of the function there is no return call.

Suggested solution:

Just add a return call.