search

vincent-maillou / qttools

Quantum Transport Algorithms Toolbox
GNU General Public License v3.0
5 stars 1 forks source link

Proposed fix for issue #62 #63

Open awinka opened 1 day ago

awinka commented 1 day ago

resolves #62

codecov-commenter commented 1 day ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.00%. Comparing base (3fac381) to head (d47b61c).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #63 +/- ## ========================================== + Coverage 84.80% 85.00% +0.19% ========================================== Files 29 29 Lines 1198 1200 +2 ========================================== + Hits 1016 1020 +4 + Misses 182 180 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚨 Try these New Features:

awinka commented 1 day ago

Thanks for finding all the bugs i implemented in the data structure 🙏 Are you actually using .ltranspose() with copy=True somewhere in quatrex? Or did you just stumble on this while testing something else?

In any case changes LGTM

I tried to symmetrice the lesser/greater quantities to see if that helped with the negative peaks (it didn't change anything), so that was when I used it.