search

vincentb1 / fmtcount

Source for LaTeX fmtcount package
11 stars 5 forks source link

documentation needs updating? #34

Closed FrankMittelbach closed 6 years ago

FrankMittelbach commented 6 years ago

The text

As with all commands which have an optional argument as the last argument, if the optional argument is omitted, any spaces following the final argument will be ignored. Whereas, if the optional argument is present, any spaces following the optional argument won’t be ignored. so \ordinal{section} ! will produce: 3rd! whereas \ordinal{section}[m] ! will produce: 3rd !

isn't any longer true as a special version of \@ifnextchar is used

vincentb1 commented 6 years ago

I think that you are right — I need to do some testing to confirm this new behaviour.

While scanning the code, I noted that \storeordinalnum, \storeNumberstringnum, \storeNUMBERstringnum such suchlikes are still using the old \@ifnextchar. Similarly \storeNUMBERstring is just a wrapper on top of \storeNUMBERstringnum, so it will also have the \@ifnextchar. OK, the \storeΩ commands — where Ω is whatever applicable — are probably less likely to be inserted in the flow of the text. @nlct is that just we forgot to fix them, or is it a desired behaviour to continue using the old one.

vincentb1 commented 6 years ago

Hello, Just to say that I have pushed some fix to the repo, still on branch version_3.05+.

FrankMittelbach commented 6 years ago

looks good to me, thanks