search

vincentchan / mickey

A minimal one-column theme for Jekyll.
Other
335 stars 225 forks source link

Removes relative_permalinks that are no longer supported by jekyll #18

Open lucasmbraz opened 6 years ago

lucasmbraz commented 6 years ago

Hi,

I really liked your theme but when I tried it jekyll couldn't build it because of relative_permalinks=true on the config file. Also, github pages no longer uses redcarpet and doesn't support pygments highlighter.

This is my attempt at fixing it. It seems to work for me but I'm not a web dev so I'm not very sure.

I followed this to fix the broken links http://downtothewire.io/2015/08/15/configuring-jekyll-for-user-and-project-github-pages/

smashism commented 6 years ago

I just wanted to say thank you for your time and effort to work on this update to this template. It's pretty much perfect for a project I'm working on and I've tested and validated that your changes work (at least locally) do the trick. 🙏🏻Hopefully it gets merged so other folks can use it too.

lucasmbraz commented 6 years ago

Thanks for the feedback. I'm really glad it helped you.