search

vinkla / laravel-hashids

A Hashids bridge for Laravel
MIT License
2k stars 173 forks source link

Existing ids could unknowingly change when updating composer #102

Closed robido closed 5 years ago

robido commented 5 years ago

Based on the hashids docs your composer should specify an exact version of hashids. So I suggest replacing: "hashids/hashids": "^3.0", by "hashids/hashids": "3.0.0",

Right now, I specify a fixed version of your project in my composer like so: "vinkla/hashids": "5.1.0",

If the developpers of hashids make a small change in the generation algo, the ids could change after I run the composer update command.

A change in ids would break the SEO of my website and I might not even notice it.

vinkla commented 5 years ago

You don't need to worry about this. If hashids/hashids updates the algorithm they will release it as a major version. When they release a major version I'll release a major version of this package as well. It should be fine using version ^5.1 in your composer.json file.

robido commented 5 years ago

Tack!