vinkla / laravel-hashids

A Hashids bridge for Laravel
MIT License
2k stars 173 forks source link

Added a asset group tag #115

Closed memochou1993 closed 5 years ago

memochou1993 commented 5 years ago

This command is more appropriate. Tks.

php artisan vendor:publish --tag=hashids
vinkla commented 5 years ago

Thanks for the pull request!

This command is more appropriate.

I've no idea what this means and why this feature should be added. You don't state it anywhere. There aren't even any links showcasing the feature such as Laravel's documentation. In the future, please always try to add as much information as possible.

memochou1993 commented 5 years ago

Hi, sorry for the information is not clear enough.

Without this tag, user cannot publish the specific config file. This command php artisan vendor:publish will show all the assets, like this:

image

There is nohashids config file, because the asset of this package does not have a group tag. By adding the tag, and using the command php artisan vendor:publish, user can see the package config file in the list, like this:

image

Or, user can use the command php artisan vendor:publish --tag=hashids, and publish the config file directly.

image

More information, please check Laravel docs: https://laravel.com/docs/6.0/packages#public-assets

Thanks!

vinkla commented 5 years ago

Thanks for taking the time to add more information!

From what I'm reading in the documentation it seems that the tag is used to target public, config and migrations. I've also checked other Laravel packages and this doesn't seem that common.

Thanks for the pull request but I currently wont merge this.