search

vintagepc / MK404

A functional Simulator for Prusa (Mini/Einsy) Rambo based printers
https://vintagepc.github.io/MK404/
GNU General Public License v3.0
72 stars 9 forks source link

Use consistent __attribute__((__packed__)) #339

Closed GilesBathgate closed 3 years ago

GilesBathgate commented 3 years ago

Description

Code consistency. In some places __attribute__((__packed__)) was used in others __attribute__((packed)). I can't find any documentation that supports the later version but it could possibly be old syntax that still works in gcc.

Behaviour/ Breaking changes

No behavioural changes are expected.

codecov[bot] commented 3 years ago

Codecov Report

Merging #339 (f05e944) into master (c1a0c6b) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #339   +/-   ##
=======================================
  Coverage   91.14%   91.14%           
=======================================
  Files         166      166           
  Lines        7692     7692           
=======================================
  Hits         7011     7011           
  Misses        681      681
Impacted Files Coverage Δ
parts/I2CPeripheral.h 100.00% <ø> (ø)
parts/components/MCP23S17.h 100.00% <ø> (ø)
parts/components/SDCard.h 100.00% <ø> (ø)
parts/components/TMC2130.h 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c1a0c6b...f05e944. Read the comment docs.

vintagepc commented 3 years ago

The ones using the second form look to have been imported third party code, hence the inconsistency :)