vinzscam / backstage-chart

Backstage Helm Chart
27 stars 10 forks source link

feat: allow to define extra volumes and volume mounts in deployment #23

Closed froblesmartin closed 1 year ago

froblesmartin commented 1 year ago

Hi!

First of all, thanks a lot for the work done here! 😃

I am starting to use your Helm Chart to follow a standard instead of having my own.

In my case, I retrieve secrets from Azure Key Vault using the Azure Key Vault Provider for Secrets Store CSI Driver which is using a standard approach from the K8s community: https://github.com/kubernetes-sigs/secrets-store-csi-driver

To be able to mount secrets using this provider, it is required mounting the CSI driver in a pod.

In order to allow that, and probably other use cases, we can just allow defining extra volumes and volume mounts.

Please, if there is anything else to be done, just let me know :)

vinzscam commented 1 year ago

thank you, this is great @froblesmartin!

froblesmartin commented 1 year ago

Thank you @vinzscam ! Is there anything else that needs to be done?