search

viraxslot / online-school-app

Backend for testing purposes.
0 stars 0 forks source link

Created a course material with an unspecified language (Yoruba) #72

Open BeatBioInfo opened 2 years ago

BeatBioInfo commented 2 years ago

Steps to reproduce Create a collection on Postman Click on the “add request” button Use the POST method to call a request http://qa-school-test-api.quantori.academy/api/v1/session Enter the following “string” in the “Body” in the following order • { “username”: “admin”, “password”: “1234” } Press the “send” button to generate an “accessToken”. Click “Add request” to call a 'non-existing material id' in a course Use the POST method to call a request {{Host}}api/v1/courses/3093/materials/200 Enter the body { "title": "Ni àtijọ́, àwọn ọmọ ilé-iwé ló ńran àgbàlagbà ti kò lọ ", "data": "Ni àtijọ́, àwọn ọmọ ilé-iwé ló ńran àgbàlagbà ti kò lọ ilé-iwé lọ́wọ́ lati kọ iwé, pataki ni èdè abínibí", "order": 7 }

Actual behaviour • Status code: 200; Ok Body Response: { "id": 851, "title": "Ni àtijọ́, àwọn ọmọ ilé-iwé ló ńran àgbàlagbà ti kò lọ ", "data": "Ni àtijọ́, àwọn ọmọ ilé-iwé ló ńran àgbàlagbà ti kò lọ ilé-iwé lọ́wọ́ lati kọ iwé, pataki ni èdè abínibí", "order": 7, "courseId": 3093 }

Expected ### behaviour • Status code: 400 Bad request Body Response: "Only RU/EN alphabet, space and digits allowed, please change your request"

Screenshots If applicable, add screenshots to help explain your problem. image

viraxslot commented 2 years ago

@BeatBioInfo why do you want to limit that? It's totally ok to create materials in different languages :)

BeatBioInfo commented 2 years ago

@viraxslot I didn't know it was a feature as I wasn't sure it was explicitly specified in the requirement. In that case, wouldn't it be preferable to have the language feature location-based as compared to being generic?

viraxslot commented 2 years ago

@BeatBioInfo You're thinking in the right direction. I just wanted to check that. So we have 2 possibilities here:

  1. Enable all languages everywhere (not only Russian and English)
  2. Add validation rules for EN/RU everywhere.

How do you think what path should we choose?

BeatBioInfo commented 2 years ago

Yes, since we are yet to have a location based course. I think EN/RU would be suitable since that has been the standard language validation used so far.