search

virgo-agent-toolkit / rackspace-monitoring-agent

Rackspace Cloud Monitoring Agent
http://virgoagent.com/rackspace-monitoring-agent/
Apache License 2.0
118 stars 39 forks source link

Fix for plugin timeout test #992

Closed adityacb15 closed 1 year ago

adityacb15 commented 1 year ago

Since the child:kill('sigkill') is unable to kill the child process (the sleep within the timeout.sh), I used uv_kill to achieve the result.

Also, here we need to prefix a minus (-) sign in front of the processID, since that will kill all the processes under this process group (i.e, killing all attached processes/ children)

zzantozz commented 1 year ago

Your PR description is good. The same message should be on your commit. PR's don't appear in git logs when browsing them. It's important to have complete messages on the commits.

adityacb15 commented 1 year ago

Closing this PR since the approach to fix the timeout by means of changing the .sh script is not recommended. Will create a New PR, for the suggested approaches offline by Ryan