feat: add base agent - Githubissues

virt-do / lambdo

Serverless runtime in Rust

Apache License 2.0

2 stars 0 forks source link

feat: add base agent #12

Open WoodenMaiden opened 1 year ago

WoodenMaiden commented 1 year ago

Hello!

This PR aims to add the agent, whose job is:

To execute commands the api provides
To send back the standard output & standard error output to the agent.

Resolves #5 & #6

WoodenMaiden commented 1 year ago

Hey @sameo :wave:, we did some cleanup on our branch.

You might notice some things:

@Alexis-Bernard's commits are signed with @GridexX and my emails as he forgot to add the -s flag and did not have time to amend the commits himself.
Commits from c12f4af to 6517574 belong to PR #9. You should merge this first.

sameo commented 1 year ago

Hey @sameo 👋, we did some cleanup on our branch.

You might notice some things:

@Alexis-Bernard's commits are signed with @GridexX and my emails as he forgot to add the -s flag and did not have time to amend the commits himself.

Commits from c12f4af to 6517574 belong to PR Feature: add base architecture #9. You should merge this first.

I merged #9 now.

For me to review this PR, I need you to:

Rebase it on top of main
Clean your git history up. It's not important to me (the reviewer), or to anyone else looking at this repo git history to know that you fix some formatting issues with e210ec9c09d846a6009130c0ef78e7178e9a72ca, for example. Structure your git history into commits that show how you logically implemented the feature this PR is bringing.

GridexX commented 1 year ago

Hello @sameo We both have Rebase it on top of main and clean our git history up without the fix and chore commits.

The PR is ready to be reviewed :smile:

WoodenMaiden commented 1 year ago

Here are the fixes, I hope these are okay

sameo commented 1 year ago

Please rebase this PR on top of main. Do not try to merge main back into it. Let me know if you need help with this.

GridexX commented 1 year ago

@sameo @WoodenMaiden I completely rewrite the commits history, and we add your changes with Yann. 4 commits are from @iverly, because they are on our main branch and the PR where the changes were made need to be merged first :+1: