search

virtualmin / virtualmin-gpl

Virtualmin web hosting control panel for Webmin
https://www.virtualmin.com
GNU General Public License v3.0
376 stars 118 forks source link

Virtualmin database GUI: "There are too many tables to display": add a link to where we can increase the number of tables to display #1003

Open marclaporte opened 2 months ago

marclaporte commented 2 months ago

When a database has too many tables, it's easy to solve: increase the maximum to display. However, most site admins will have trouble finding the setting. Image

@jcameron: @iliajie explained to me that this is not simple to address with the current design so just adding here as a longer term issue.

Thanks!

iliajie commented 2 months ago

Thanks Marc!

I believe we need to switch to using the new table pagination API that I added some time ago. We are currently using it in "Users and Groups" module only.

jcameron commented 2 months ago

The reason for this limit is that for each table or DB we display, Webmin has to fetch the number of tables and rows respectively to generate that table. And this can get pretty slow, even if we use a paginated display.

iliajie commented 2 months ago

And this can get pretty slow, even if we use a paginated display.

Counting tables/indexes is almost instantaneous, but counting rows and fields can be slow. For paginated tables, could we count only the rows and fields on the current page while using the total number of tables/indexes to build the pagination itself?

jcameron commented 2 months ago

In theory yes we could build this ... take a shot if you like!