virtualmin / virtualmin-gpl

Virtualmin web hosting control panel for Webmin
https://www.virtualmin.com
GNU General Public License v3.0
376 stars 118 forks source link

Add support for the new navigation menu layout #1020

Closed iliajie closed 1 month ago

iliajie commented 1 month ago

Hello Jamie!

As we discussed a while back in the chat, here’s the PR that adds support for the new menu layout. This update also addresses issues with labels for virtual servers, sub-servers, and alias servers.

The mail feature for alias domains is now called “Mail for alias” and has its own help tip, since there’s no way to edit mail settings for the domain—I wanted to keep things clear.

Also, let’s discuss whether a home directory is really necessary for an alias with its own mail, and if auto-replies work as intended or are needed at all?

Below are some examples of the reworked menu layout (supported in current Webmin 2.302), based on Joe’s suggestions and numerous user suggestions:

Create top-level domain menu and form

image

Create sub-server domain menu and form

image

Create alias in top-level domain menu and form

image

Edit sub-domain menu and form

image

Edit alias server menu and form

image
jcameron commented 1 month ago

Thanks! Added one comment, but overall this looks good!

iliajie commented 1 month ago

Thanks! Added one comment, but overall this looks good!

Thank you—fixed now.

jcameron commented 1 month ago

Two more small things :

1 - We shouldn't show "Virtual Server Summary" if "Edit Virtual Server" is also shown, because they basically show the same thing.

2 - Can the "Create Virtual Server" button at the top be red or something? This would be best done in the theme

iliajie commented 1 month ago

Two more small things :

1 - We shouldn't show "Virtual Server Summary" if "Edit Virtual Server" is also shown, because they basically show the same thing.

2 - Can the "Create Virtual Server" button at the top be red or something? This would be best done in the theme

Yeah, both are controlled by the theme and are unrelated to this patch.

  1. The "Virtual Server Summary" link has been shown for ages—users are accustomed to it, and it’s useful since it offers a quick overview of the virtual server, with details not available on the "Edit Virtual Server" page.

  2. As for the button, I can experiment with it further. It’s not yet clear how to improve its look and feel.

jcameron commented 1 month ago

For the button color, I feel like it would be consistent with other web apps where the "create" or "compose" button is highlighted. Just a suggestion though ..

iliajie commented 1 month ago

For the button color, I feel like it would be consistent with other web apps where the "create" or "compose" button is highlighted. Just a suggestion though ..

I'll consider it! Thank you!

iliajie commented 1 month ago

For the button color, I feel like it would be consistent with other web apps where the "create" or "compose" button is highlighted. Just a suggestion though ..

I'll consider it! Thank you!

There aren't many colors we can use with blue. How about something like this?

image - ff1f0094 image - ff1f0064

jcameron commented 1 month ago

Yeah I like that! @swelljoe what do you think?

iliajie commented 1 month ago

I have given it a fresh look, and while isolated screenshots look fine, they don't seem to work well when combined on the page (with right side). This is because red buttons usually convey a completely opposite, destructive meaning, such as delete or remove. Additionally, there are numerous other left menu palettes, and using red on them won't work either. Therefore, I believe the best solution is to use a highlight or contrast color, like this:

imageimageimage