search

virtualmin / virtualmin-gpl

Virtualmin web hosting control panel for Webmin
https://www.virtualmin.com
GNU General Public License v3.0
320 stars 101 forks source link

TOTP authenticator UI strings only mention "Google Authenticator" specifically, instead of being generic #946

Open nekohayo opened 6 days ago

nekohayo commented 6 days ago

Based on this thread and what I see on my personal server running Virtualmin 7.20.2 + Webmin 2.202 + Usermin 2.102 from your Debian 12 repositories, it seems that VirtualMin, Webmin, Usermin have support for TOTP 2FA; if I am not mistaken, that support is generic, independent of which exact application is used, yes?

If so, it would probably be good to do some grepping / search-and-replace across all three codebases to make it generic and not only mention Google Authenticator specifically. There are plenty of other apps out there that your users might want to use, but currently when looking at the UI I can't be sure that I can, because it says "Google Authenticator" specifically. I mean, I have a guess, but I'm not sure, and less geeky users may not know at all. In addition to linking to a neutral list of applications, it could be fine to mention Google Authenticator as an example in a (?) help tooltip for convenience, just not present it as the only thing?

This is the same logic/recommendation as I have made in Tiki.

iliajie commented 6 days ago

Hello Jeff!

Thanks for the heads up! Could you try nightly Webmin version and see if the problem is solved?

nekohayo commented 6 days ago

Oh, I did not expect that you were already independently fixing this in the dev version :)
Unfortunately I don't think I have an easy way to test that here. Do you have an idea of approximately when this might reach the stable releases of those three components? If so I can make myself a reminder note to retest and come back to close this ticket at that time.