visitscotland / vs-component-library

VisitScotland Component Library
Other
0 stars 0 forks source link

Carbon Calculator: Accessibility - Number Input component buttons need to have discernible text #249

Closed BrianGibbVS closed 1 week ago

BrianGibbVS commented 1 year ago

Raised by

Brian Gibb

Describe the bug

In the Carbon Calculator questions for How many hours will your journey take? and How many nights are you staying for? both use a number input component with +/- buttons to increment / decrement the value entered and used.

These buttons do not have discernible text associated with them.

To Reproduce

Steps to reproduce the behavior:

  1. Go to Carbon Calculator page
  2. Conduct an Accessibility Scan on each of the Carbon Calculator steps.
  3. See screenshots.

Expected behavior

Buttons must have discernible text that clearly describes the destination, purpose, function, or action for screen reader users.

Page URL

https://www.visitscotland.com/travel-planning/responsible-tourism/carbon-calculator

Environment

All

Browser

All

Device and version

N/A

Impact on end user

THe NVDA screenreader simply reads out "button" when the +/- elements are tabbed to, giving no context to accessible users as to their purpose.

Impact on product development

N/A

Additional context

N/A

BrianGibbVS commented 1 year ago

buttonsdescernibletext