search

vitalets / x-editable

In-place editing with Twitter Bootstrap, jQuery UI or pure jQuery
http://vitalets.github.io/x-editable
MIT License
6.51k stars 1.72k forks source link

Consider using trigger vs triggerHandler for custom editable events #86

Open vladar opened 11 years ago

vladar commented 11 years ago

The problem I faced with is that triggerHandler doesn't bubble, so it's impossible to use event delegation with it.

I saw you added "selector" option recently, so enabling event delegation seems reasonable as well.

The only problem I envision is possible conflicts in event names with bootstrap, e.g. If I bind to bootstrap's modal "hidden" event and editable inside this modal triggers it's own "hidden" event - it will bubble up and trigger modal's handler.

Not sure how to handle this properly - maybe it's worth to namespace triggered events, but this will cause a BC break.

vitalets commented 11 years ago

Agree with all points. I think in major release to add namespace to events (that can be turned off by option for BC) thank you!

gordol commented 9 years ago

hmm... any progress on this? i'm having issues currently with trying to bind to .editable hidden event on dynamically added content. http://jsfiddle.net/rced7kp1/ perhaps someone has a work-around?

gordol commented 9 years ago

so i got it sorted by patching x-editable to use trigger() instead of triggerhandler() for the hidden event. i imagine if i was putting editable items into overlays or something that would be problematic, but it seems to work fine for my uses.

zamnuts commented 9 years ago

+1 on this enhancement, X-editable keeps all the goodies internal with triggerHandler :(

gordol commented 9 years ago

https://github.com/vitalets/x-editable/issues/610 seems this project is basically abandoned

There are lots of forks and pull requests open, but nobody merging them back in.