Open RansomTime opened 11 months ago
Opened #2 with that change to the build script
Hi, I see in your PR that after all Yarn was not related to this? It really shouldn't, as I only used npm with this project from the start. I've just tried reproducing the readme instructions on a fresh clone and they worked for me without any use of Yarn... can you confirm that the brace expansion was the only problem, after all?
% npm --version
9.8.1
% node --version
v20.6.1
To make myself completely clear, I've been using the NPM package manager, not the Yarn package manager, so the instructions really shouldn't have anything to do with Yarn.
ransom@Frarn:glucoscape$ npm --version
10.2.0
ransom@Frarn:glucoscape$ node --version
v21.1.0
without running yarn install the build couldn't find webpack and husky.
It could be that yarn install put some global dependencies in that made everything work. I did see both of those in the dev dependencies though so I assume they would have been installed by npm install.
I have recloned the repo and it works now with just an npm install and npm build (with the brace issue fixed)
I'm not an expert on the JS ecosystem, but I found this: https://stackoverflow.com/questions/34700610/npm-install-wont-install-devdependencies
Is it possible you had/have NODE_ENV=production
somewhere in your environment? Perhaps I could change the instructions to say npm install --also=dev
to be sure...
Heya,
I'm trying to build this using your readme.md
The instructions you gave didn't work - but adding in an yarn install did.
In addition, the build script failed on my shell, didn't like the brace notation, expanding it to
worked a treat