mysqldump: fails with default options

morgo commented 4 years ago

mysqldump currently requires a number of options to work successfully. This convenience issue tracks what those options are, and the related issues:

[x] (no option: SET SQL_QUOTE_SHOW_CREATE) https://github.com/vitessio/vitess/issues/5522
[x] --lock-tables=off https://github.com/vitessio/vitess/issues/5402
[x] --skip-network-timeout https://github.com/vitessio/vitess/issues/5401 (8.0 only)
[ ] --set-gtid-purged=OFF https://github.com/vitessio/vitess/issues/5403
[x] --quote-names (issue not created yet)
[ ] --no-tablespaces (issue not created yet)

A workaround to disable all of these is as follows:

# mysql 5.7
mysqldump  --lock-tables=off --quote-names --set-gtid-purged=OFF --no-tablespaces commerce

# mysql 8.0
mysqldump  --lock-tables=off --quote-names --set-gtid-purged=OFF --no-tablespaces --skip-network-timeout commerce

harshit-gangal commented 3 years ago

default is on for quote-names. I think it should not be an issue.

hallaroo commented 3 years ago

Additional tracking of issues:

harshit-gangal commented 3 years ago

Two more issues reported:

deepthi commented 3 years ago

As we discussed offline, it is reasonable to not support mysqldump with default options as long as we clearly document how to use it. Documentation that needs to be reviewed/updated: https://vitess.io/docs/user-guides/configuration-basic/exporting-data/#mysqldump https://vitess.io/docs/user-guides/migration/migrate-data/

We say we recommend go-mydumper but we should document how to use mysqldump as well.

harshit-gangal commented 3 years ago

I think we should document how to move data to Vitess using VReplication and recommend that over go-mydumper or mysqldump

deepthi commented 3 years ago

We already have the docs. Maybe we should move the VReplication method to the top and push "stop-the-world" to second place.

vitessio / vitess