search

viti95 / FastDoom

Doom port for DOS, optimized to be as fast as possible!
528 stars 33 forks source link

Visual Error on E2M2 Demo/Screen Melt Transition #200

Closed ezgoodnight closed 4 months ago

ezgoodnight commented 4 months ago

MiSTer FPGA on the ao486core, DOS 6.22

Pretty noticeable visual error happening at the end of the E2M2 demo. Vanilla does not appear to do this.

fastdoom visual errors.webm

I've been able to reproduce it twice, just seems to happen every time the E2M2 demo ends.

viti95 commented 4 months ago

Can you share FastDoom version and executable used? Also, can you check what Doom WAD version do you have?

ezgoodnight commented 4 months ago

FastDoom Latest 0.9.9e I don't think I've loaded anything but FDSETUP.EXE, which I assume loads FDOOM.EXE?

MD5: c4fe9fd920207691a9f493668e0a2083 WAD File: The Ultimate DOOM (v1.9)

ezgoodnight commented 4 months ago

I checked this WAD in DosBox X and it crashes Vanilla Doom after E2M2 with the error

W_GetNumForName: HELP2 not found!

I am guessing this link is relevant. Is FastDoom looking for HELP2 and creates this error?

ezgoodnight commented 4 months ago

This visual error happens with this same WAD in DOSBox-X as well, so not a MiSTer FPGA issue. image

viti95 commented 4 months ago

Question, is the WAD file named DOOM.WAD or DOOMU.WAD ?

ezgoodnight commented 4 months ago

Simply "doom.wad"

viti95 commented 4 months ago

Oook I think that is what is causing issues. The Ultimate Doom WAD should be named doomu.wad in order to work properly.

ezgoodnight commented 4 months ago

All versions I just checked, including the commercially available version from GOG, have it labeled as DOOM.WAD despite being Ultimate Doom. I think most people's Ultimate Doom Wads are going to be named with that convention.

I think it would be useful to update the Readme for users to rename their ultimate doom wads as DOOMU.WAD and/or check their hashes first.

Most source ports these days seem let users treat Doom 1 Wads sort of interchangeably, but I can understand your commitment to keeping FastDoom so vanilla.

I can confirm that changing it to DOOMU.WAD does indeed load the first slide again, fixes this particular issue.

viti95 commented 4 months ago

Good idea on checking the hash first. The only issue that a 386 is slow, so I'll add a check for WAD size and modify the readme, I guess that should be enough. Thanks for testing.