search

vitrivr / vitrivr-engine

vitrivr's next-generation retrieval engine. It is capable of extracting and retrieving a wider range of multimedia objects such as audio, video, images or 3d models.
https://vitrivr.org
MIT License
6 stars 3 forks source link

Migration to kotlinx #82

Closed faberf closed 3 months ago

faberf commented 4 months ago

Addresses #79, by switching to kotlinx. The KotlinxJsonMapper is still not finished, so this PR is a draft.

faberf commented 4 months ago

@ppanopticon Regarding the jsonmapper, I have just naively removed the fallback mapper and it seems to work for the queries that I tested. For queries / return values with lists of complex objects, the developer just needs to ensure that they use the correct ArrayLists and serializable decorators... Maybe I misunderstood the assignment?

ppanopticon commented 4 months ago

So did you test the endpoints that return Lists as response?

faberf commented 3 months ago

Hey, I have added a serializable wrapper to the schema list endpoints output and implemented some unit tests. I don't think there are any other endpoints at the moment that return raw lists, so IMO this PR is ready to merge.

ppanopticon commented 3 months ago

Did some cleanup and removed the actual dependencies to Jackson, GSON and Mosho. This PR is good to go. Thanks @faberf