search

vittoriozamboni / django-groups-manager

Manage django groups collection based on django-mptt.
MIT License
96 stars 23 forks source link

Broken with Django 4.0 #59

Closed Gornoka closed 2 years ago

Gornoka commented 2 years ago

Currently this does not work with Django 4.0 as far as I could see the only problem is the usage of the deprecated alias 

django.conf.urls.url

I would propose a quick fix later, however it should be discussed whether the old behaviour of using the alias is still kept for backwards compatibility or not.

Gornoka commented 2 years ago

Context regarding the deprecated function: https://docs.djangoproject.com/en/1.8/ref/urls/#url https://docs.djangoproject.com/en/2.0/ref/urls/#url The function is already deprecated since 1.8 and has been an alias for re_path since 2.0 I would consider removing it entirely, the current pr #60 still keeps it as a backup in case of an ImportError.

vittoriozamboni commented 2 years ago

Hi @Gornoka , thank you for flagging the issue and providing a PR to fix it, maintaining the old functionality as well. I will merge it and fix the test project as well, so the tests can pass. I will release a new version after it.