Nikos Mynhier @nikashmyn informed me of a bug in some vivarium notebooks, which failed to generate topology plots of composites after division. For example, this would fail. Looking into it, I found that the composite specification that is passed into Engine was no longer referencing the same Engine.processes and Engine.flow instances -- this happens because when building the store, we reassign these after parallelizing the process. I fixed it by simply putting these back in the composite.
I also found flow was not updating after division, and put in some fixes for that.
A new test_hierarchy_update is in place to assure this functionality is maintained.
By creating this pull request, I agree to the Contributor License
Agreement, which is available in CLA.md at the top level of this
repository.
Nikos Mynhier @nikashmyn informed me of a bug in some vivarium notebooks, which failed to generate topology plots of composites after division. For example, this would fail. Looking into it, I found that the composite specification that is passed into
Enginewas no longer referencing the sameEngine.processesandEngine.flowinstances -- this happens because when building the store, we reassign these after parallelizing the process. I fixed it by simply putting these back in the composite.flowwas not updating after division, and put in some fixes for that.test_hierarchy_updateis in place to assure this functionality is maintained.By creating this pull request, I agree to the Contributor License Agreement, which is available in
CLA.mdat the top level of this repository.