vkdolea / age-system

Unofficial implementation of AGE System (Green Ronin) for Foundry VTT
Apache License 2.0
12 stars 16 forks source link

Enhancement: Additional effect key attribute key to count magical/poison damage #117

Open remyke opened 11 months ago

remyke commented 11 months ago

In Dragon Age poison and magical effects like Frost Weapons are counted as additional penetration or test based damage on top of the weapon's damage and likely penetrationg.

vkdolea commented 10 months ago

When configuring damage from Weapon or Powers/Spells, there is already an option to add that damage as Penetrating, as you can see in the following image. image

Maybe the solution your are aiming is way simpler than adding new features on Item or Actor. I suspect the dialog window opened to Apply Damage could identify the damage source (which is already inside chat message Data) and select the damage as "Ignore Armor", as it is now in the image bellow: image

I can implement it fairly easy from my end.

remyke commented 10 months ago

I checked the damage part of the item as well, but you can define only a single damage with its type. The modification is using the same type so if the attack is success, but the items damage is not high enough to reach the armor the additional penetrating part of the damage is not dealt which should be.

I considered to add another active item to the token with the desired penetrating damage, but in the damage only one item counts and the additional items damage is ignored. Also the time limit duration is implemented well in case of active effect.

My goal is to add this feature with the les possible gm administration and the right amount of visibility.

vkdolea commented 10 months ago

The best approach world be modifying Item data modelo to allow multiple damage field, where you could add item as penetranting or not.

When clicking to roll damage, one damage card would appear for each damage component.

GM would apply the 1st damage part and would then manually apply the second damage part to targets that received damage.

This would be a modification which would require modifications on codes from template, item and sheet. I suspect migration would also be necessary to implement the new data model to all items.

I understand this proposal will keep the code in line with the system and offer enough automation to accomplish the desired feature.

remyke commented 10 months ago

I would prefer the one card handling the damages in one go and maybe be able to ignore damage per target per damage type. Also keep in mind my draft regardless of the actor or item model is extended not covers everything as it is possible some damages in this modifier type has their own prevention rolls like willpover self-discipline.