vladmihalcea / high-performance-java-persistence

The High-Performance Java Persistence book and video course code examples
Apache License 2.0
1.29k stars 486 forks source link

ResourceLocalDelayConnectionAcquisitionTest should not depend on oracle.xml.parser.v2.XMLElement.XMLElement #7

Closed ursjoss closed 7 years ago

ursjoss commented 7 years ago

Hi Vlad

ResourceLocalDelayConnectionAcquisitionTest depends on XMLElement (oracle.xml.parser.v2.XMLElement.XMLElement) which seems to be part of the oracle XDK tools. If you don't have them installed, you can't build the project (see part of the stack trace below).

Looks like XDK tools don't come via maven central and need some process of installation. I did not invest a lot of time, but it's not simply straight forward to get hold of this class. Not sure if it's a good idea to depend on this class. You might want to consider replacing that class with something standard if feasibly possible.

Thanks Urs

[INFO] -------------------------------------------------------------
[ERROR] COMPILATION ERROR : 
[INFO] -------------------------------------------------------------
[ERROR] /home/urs/work/git/other/high-performance-java-persistence/core/src/test/java/com/vladmihalcea/book/hpjp/hibernate/connection/ResourceLocalDelayConnectionAcquisitionTest.java:[31,28] package oracle.xml.parser.v2 does not exist
[ERROR] /home/urs/work/git/other/high-performance-java-persistence/core/src/test/java/com/vladmihalcea/book/hpjp/hibernate/connection/ResourceLocalDelayConnectionAcquisitionTest.java:[167,41] cannot find symbol
  symbol:   class XMLElement
  location: class com.vladmihalcea.book.hpjp.hibernate.connection.ResourceLocalDelayConnectionAcquisitionTest
[INFO] 2 errors 
[INFO] -------------------------------------------------------------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] high-performance-java-persistence .................. SUCCESS [  1.709 s]
[INFO] high-performance-java-persistence-core ............. FAILURE [  6.947 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 8.832 s
[INFO] Finished at: 2017-05-21T08:39:56+02:00
[INFO] Final Memory: 32M/251M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.2:testCompile (default-testCompile) on project high-performance-java-persistence-core: Compilation failure: Compilation failure:
[ERROR] /home/urs/work/git/other/high-performance-java-persistence/core/src/test/java/com/vladmihalcea/book/hpjp/hibernate/connection/ResourceLocalDelayConnectionAcquisitionTest.java:[31,28] package oracle.xml.parser.v2 does not exist
[ERROR] /home/urs/work/git/other/high-performance-java-persistence/core/src/test/java/com/vladmihalcea/book/hpjp/hibernate/connection/ResourceLocalDelayConnectionAcquisitionTest.java:[167,41] cannot find symbol
[ERROR] symbol:   class XMLElement
[ERROR] location: class com.vladmihalcea.book.hpjp.hibernate.connection.ResourceLocalDelayConnectionAcquisitionTest
[ERROR] -> [Help 1]
vladmihalcea commented 7 years ago

Fixed.

ursjoss commented 7 years ago

Thank you, Vlad!