vladyslav-burylov / resharper-testlinker2

Easy navigation between test and production code.
MIT License
6 stars 4 forks source link

First automated release #6

Closed vladyslav-burylov closed 2 years ago

vladyslav-burylov commented 2 years ago

Hi @mu88 - FYI - 2021.3 build seems to be failed, however it looks like it was actually uploaded to Jet Brains - I've got confirmation e-mail.

Attaching binary which was uploaded

testlinker2-2021.3.zip

vladyslav-burylov commented 2 years ago

BTW - I have slack account inside JetBrains Platform slack namespace, you may reach to me here if you will ever need real-time discussion

My profile: https://jetbrains-platform.slack.com/archives/D01G9C27E4B How to join: https://plugins.jetbrains.com/slack

mu88 commented 2 years ago

Ah great to know!

I've modified the publish step so that it won't fail next time (hopefully).

Can you already download the new plugin from JetBrains?

vladyslav-burylov commented 2 years ago

Not yet - JetBrains reviewing each update (it takes approximately 1-2 days given my previous experience)

image

vladyslav-burylov commented 2 years ago

The good news is that binary seems to be OK:

image

Although, I have no idea how exactly jetBrains verify compatibility

vladyslav-burylov commented 2 years ago

@mu88 - I will let you know once plugin will be approved

mu88 commented 2 years ago

This is good news! I'm curious whether everything is fine :)

Was the proceeding with this release okay for you? Would you prefer a PR-driven approach, e. g. for having a cleaner commit line in master?

And do you know whether there is some kind of "staging environment" at JetBrains so that we could test the release procedure without actually creating a "real" new release?

vladyslav-burylov commented 2 years ago

Hi mu88

Was the proceeding with this release okay for you?

For sure - that's exactly why why I given you direct commit permissions - I recently switched to a different tech stack and use .NET occasionally now - so, I'd like to be sure this plugin can be updated w/o my involvement - otherwise there would be delays. Please feel free to continue; I don't see big issue w/r to master branch history simplicity - it's only few people who are looking at this now.

And do you know whether there is some kind of "staging environment" at JetBrains?

Nope, unfortunately.. Also, I don't see big issue here - within 2-3 Rider updates we should be able to fix all build-script issues and achieve full automation. Moreover - it already works net of github action failures.

p.s. appreciating your contribution - please feel free to add your name to the license :)

mu88 commented 2 years ago

For sure - that's exactly why why I given you direct commit permissions

I'm glad to hear 😊

p.s. appreciating your contribution - please feel free to add your name to the license :)

Ouh thanks a lot, I really do appreciate!

What do you think, let's close this issue?

vladyslav-burylov commented 2 years ago

Hi mu88 - yes, I will close it once plugin will be approved

vladyslav-burylov commented 2 years ago

Plugin has been approved - closing