search

vmangos / core

Progressive Vanilla Core aimed at all versions from 1.2 to 1.12
GNU General Public License v2.0
692 stars 493 forks source link

🐛 [Bug] Mountain Cougar clipping issues when using the modern client through HermesProxy #2189

Open mserajnik opened 1 year ago

mserajnik commented 1 year ago

🐛 Bug report

I've recently started leveling a Tauren on a private VMaNGOS instance and noticed some severe ground clipping issues with the Mountain Cougars in Red Mesa Cloud, to an extent I haven't seen with other mobs in the past.

Note that I'm using a 1.14.0 client (via HermesProxy), but I assume this issue is probably strictly server-side (mmap-related?) and would also occur on an actual vanilla client. I've re-extracted the client data with the latest commit just to rule out an issue there.

While it also looks like there is some lag in the video (with the Mountain Cougar walk animation playing without them actually moving in some cases), this was recorded using a local server with very little latency, so that shouldn't be part of the issue.

Edit: I've actually tried with a 1.12.1 client on my Steam Deck now and was not able to reproduce this issue; the Mountain Cougars moved just fine, without any clipping or animation glitches. So this problem seems to be specific to the 1.14.0 client using HermesProxy. I'll leave this issue open still since I saw that you are implementing changes/fixes related to HermesProxy (e.g., https://github.com/vmangos/core/commit/13fec327e6a4086eb2252f3a8b20c093e82ea12b), so I assume this might be of interest.

I've seen some other, more minor instances of such clipping and also line of sight problems (where moving out of mob line of sight, e.g., behind a corner, doesn't cause casts to get interrupted and mobs just keep casting through the wall) when playing with the modern client; I didn't make the connection before and thought of them as mmap/vmap inaccuracies, but these are probably also specific to HermesProxy and related to this specific issue then.

If this is something that has to be fixed in HermesProxy rather than server-side, feel free to close this issue. I couldn't find anything relating to issues like that on their bug tracker though.

https://github.com/vmangos/core/assets/80664890/8575ee1f-d96e-4395-b7f6-5baeedb47b61

Expected behavior

I can't test this myself on current WoW Classic, but based on video material such as this one the Mountain Cougars shouldn't have any pathing/clipping issues.

Steps to reproduce

  1. Use the modern WoW Classic client through HermesProxy
  2. .go xyz -3388.66 -484.83 80.98
  3. Observe the Mountain Cougars in the area and notice the clipping issues

Version & Environment

Client Version: 1.14.0 (using HermesProxy)

Commit Hash: https://github.com/vmangos/core/commit/05d8f8a3b72e97bd5c806343eab967a053634762

OS Client: macOS 13.5.1 OS Server: Ubuntu 22.04

Crashlog

mserajnik commented 1 year ago

I've just tested this with a 1.12.1 client on my Steam Deck and couldn't replicate the issue, so this is probably specific to the modern client after all; I've adjusted the issue details accordingly.