Subscription doesn't valid function - Githubissues

vmware-archive / dispatch

Dispatch is a framework for deploying and managing serverless style applications.

http://dispatchframework.io

Apache License 2.0

532 stars 58 forks source link

Subscription doesn't valid function #760

Closed pzmrzy closed 5 years ago

pzmrzy commented 5 years ago

Bug Report

When create a subscription with a function doesn't exist, the subscription is still ready

Expected behavior

Dispatch should return error when create a subscription with invalid function.

Current behavior

Steps to reproduce

create eventdrivertype some_event_type
create eventdriver by dispatch create subscription xxx --name test --event-type some_event_type
run dispatch get subscription, it will return a subscription with function name xxx

Impact

[ ] Low - Annoyance, but does not impact business or functionality
[ ] Medium - Issue can be worked around, but is causing pain
[ ] High - Blocker

kars7e commented 5 years ago

The subscription itself is ready. Constantly validating if function exists is an overkill. Adding dependency check (don't allow to delete function that has subscription depending on it) makes more sense.

Anyway, this is covered in https://github.com/vmware/dispatch/issues/30