VrClientReply should be it's own message separate from the VrMsg protocol message enum, which perhaps should be renamed to VrProtocol, and the new VrClientRequest enum.
Since they will still all likely need to be bundled into a single enum for usage in vr_fsm and vr_ctx, the new enum could look like this:
This of course will result in a bit of churn to the VR code, but it will be worth it for the added strong typing safety that will clarify functions and prevent the need to use unreachable!() like this.
A VR log should only contain
ClientRequest
andReconfiguration
variants. These should exist in their own enum, something like:VrClientReply
should be it's own message separate from theVrMsg
protocol message enum, which perhaps should be renamed toVrProtocol
, and the newVrClientRequest
enum.Since they will still all likely need to be bundled into a single enum for usage in
vr_fsm
andvr_ctx
, the new enum could look like this:This of course will result in a bit of churn to the VR code, but it will be worth it for the added strong typing safety that will clarify functions and prevent the need to use
unreachable!()
like this.This should be done after the fix to #90.