Fail kops commands gracefully for vsphere

[prashima]

Fail gracefully for vsphere cloud provider, while executing following kops commands-

1. create instancegroup
2. delete instancegroup
3. replace
4. rolling-update
5. toolbox dump
6. toolbox convert-imported
7. update cluster (filing a separate issue)
8. upgrade cluster

'edit' and 'update' commands for federation are yet to be investigated. They might also make to this list.

[prashima]

One more addition-

9. import cluster

[prashima]

Some more commands made to this list:

10. delete instancegroup
11. delete -f FILENAME
12. edit cluster
13. edit ig
14. edit federation
15. update federation

[prashima]

For following commands no cloud provider is getting queried. So it's not possible to decide if a command is meant for vSphere. Additional parameters will have to be added to identify vSphere cloud provider.

• replace -f for instance groups
• edit federation
• update federation
• import cluster

[prashima]

https://github.com/vmware/kops/commit/ed42a932d175cd235a013a846735200a5ae0a7df fixes this issue, by supplying correct error message.

Commands discussed in comment above this one are yet to be fixed

• replace -f for instance groups
• edit federation
• update federation
• import cluster

[prashima]

Reduced priority, since the fix is available for common used commands. The remaining 4 commands don't get used very frequently. So a mention in doc will also do for now, in my opinion.

[prashima]

Filed https://github.com/kubernetes/kops/issues/2421 for 'import cluster' command.

For now, following commands will have to be documented as unsupported. I don't see any other way around to put a check for vSphere cloud provider, just for the duration for which they won't be supported.

• replace -f for instance groups
• edit federation
• update federation

Closing this issue. Will file a separate issue for documentation.