vmware-archive / octant

Highly extensible platform for developers to better understand the complexity of Kubernetes clusters.

https://octant.dev

Apache License 2.0

6.28k stars 481 forks source link

Updating cronjob to batchv1 #3288

Closed Freydal closed 1 year ago

Freydal commented 2 years ago

What this PR does / why we need it: Fixes an issue with cronjobs being loaded as batch/v1beta1 and the backwards conversion from batch/v1 doesn't work.

Which issue(s) this PR fixes

Fixes #2812

Special notes for your reviewer:

Release note:

Updated CronJob marshaled object from batch/v1beta1 to batch/v1

Freydal commented 2 years ago

These NPM failures look similar to some stuff I was seeing locally while toying around. I think a node wizard may need to address it.

Aankhen commented 2 years ago

Not a wizard, but the problem is the resolutions field for hosted-git-info in package.json. There’s an open npm-force-resolutions issue where people report sporadic failures with a few different syntaxes. https://github.com/rogeriochaves/npm-force-resolutions/issues/56#issuecomment-1161425697 suggests migrating to the new, builtin overrides field instead so there’s no need for npm-force-resolutions. In this case, npm ls marks both dns-packet and hosted-git-info as ‘extraneous’, so maybe those two entries could be dropped entirely.

Freydal commented 2 years ago

@Aankhen I'll look over this shortly, but I went about it differently.

3311

HighWatersDev commented 1 year ago

Hi @Freydal did you have a chance to look into this?

velvetzhero commented 1 year ago

Quite a pity it wasn't merged yet...

kadambkaluskar commented 1 year ago

Any update on this?

leosannlsn commented 1 year ago

Does merging this PR mean that batch/v1beta1 cron jobs will not be supported anymore?