search

vmware-archive / sql-to-dbsp-compiler

Compiler translating SQL view definitions into DBSP circuits (https://github.com/vmware/database-stream-processor)
Other
28 stars 5 forks source link

Preserve relation name casing #145

Open mihaibudiu opened 1 year ago

mihaibudiu commented 1 year ago

Fixes #144

mihaibudiu commented 1 year ago

@gz does this do what you want?

gz commented 1 year ago

It does seem to work. We would need to change the backend and UI in a few places to make sure that it always transforms the names to all upper or all lowercase in configs/DB. There it shouldn't be ambiguous (e.g, I presume we want that if someone goes and changes table name BlA to bla, the connections and configs should still be valid, currently we wouldn't handle that correctly with this change).

mihaibudiu commented 1 year ago

@gz so can I merge this?

gz commented 1 year ago

Let's wait till the UI + backend is prepared to deal with it, if it's not too much hassle?

mihaibudiu commented 1 year ago

Ok, I will let you merge it. Or file a new issue if more work needs to be done.