search

vmware-archive / sre-test

Greenplum - Open Source SRE test project.
2 stars 0 forks source link

extra_float_digits parameter issues #182

Closed bala-cg closed 2 years ago

bala-cg commented 3 years ago

PageNo : 1327

2 Issues 1) It will be good if the range is given in the documentation, as mentioned in Error message under "Value Range" section or .

gpadmin=# set extra_float_digits = -16; ERROR: -16 is outside the valid range for parameter "extra_float_digits" (-15 .. 3) gpadmin=#

2) with gpconfig we are able to set values out of range (-15 to 3), ideally it should throw error, however it don't take effect, it seems to be no validation is done while setting parameter using gpconfig.

[gpadmin@mdw_ipv4 ~]$ [gpadmin@mdw_ipv4 ~]$ gpconfig -c extra_float_digits -v 4 20210714:03:29:39:026837 gpconfig:mdw_ipv4:gpadmin-[INFO]:-completed successfully with parameters '-c extra_float_digits -v 4' [gpadmin@mdw_ipv4 ~]$ [gpadmin@mdw_ipv4 ~]$ [gpadmin@mdw_ipv4 ~]$ gpstop -u 20210714:03:30:03:026931 gpstop:mdw_ipv4:gpadmin-[INFO]:-Starting gpstop with args: -u 20210714:03:30:03:026931 gpstop:mdw_ipv4:gpadmin-[INFO]:-Gathering information and validating the environment... 20210714:03:30:03:026931 gpstop:mdw_ipv4:gpadmin-[INFO]:-Obtaining Greenplum Master catalog information 20210714:03:30:03:026931 gpstop:mdw_ipv4:gpadmin-[INFO]:-Obtaining Segment details from master... 20210714:03:30:03:026931 gpstop:mdw_ipv4:gpadmin-[INFO]:-Greenplum Version: 'postgres (Greenplum Database) 6.16.0 build commit:5650be2b79197fed564dca8d734d10f2a76b876c' 20210714:03:30:03:026931 gpstop:mdw_ipv4:gpadmin-[INFO]:-Signalling all postmaster processes to reload [gpadmin@mdw_ipv4 ~]$ [gpadmin@mdw_ipv4 ~]$ [gpadmin@mdw_ipv4 ~]$ gpconfig -s extra_float_digits Values on all segments are consistent GUC : extra_float_digits Master value: 0 Segment value: 0 [gpadmin@mdw_ipv4 ~]$ [gpadmin@mdw_ipv4 ~]$ [gpadmin@mdw_ipv4 ~]$ gpconfig -c extra_float_digits -v 3 20210714:06:30:41:012306 gpconfig:mdw_ipv4:gpadmin-[INFO]:-completed successfully with parameters '-c extra_float_digits -v 3' [gpadmin@mdw_ipv4 ~]$ [gpadmin@mdw_ipv4 ~]$ [gpadmin@mdw_ipv4 ~]$ gpstop -u 20210714:06:30:44:012385 gpstop:mdw_ipv4:gpadmin-[INFO]:-Starting gpstop with args: -u 20210714:06:30:44:012385 gpstop:mdw_ipv4:gpadmin-[INFO]:-Gathering information and validating the environment... 20210714:06:30:44:012385 gpstop:mdw_ipv4:gpadmin-[INFO]:-Obtaining Greenplum Master catalog information 20210714:06:30:44:012385 gpstop:mdw_ipv4:gpadmin-[INFO]:-Obtaining Segment details from master... 20210714:06:30:44:012385 gpstop:mdw_ipv4:gpadmin-[INFO]:-Greenplum Version: 'postgres (Greenplum Database) 6.16.0 build commit:5650be2b79197fed564dca8d734d10f2a76b876c' 20210714:06:30:44:012385 gpstop:mdw_ipv4:gpadmin-[INFO]:-Signalling all postmaster processes to reload [gpadmin@mdw_ipv4 ~]$ [gpadmin@mdw_ipv4 ~]$ [gpadmin@mdw_ipv4 ~]$ gpconfig -s extra_float_digits Values on all segments are consistent GUC : extra_float_digits Master value: 3 Segment value: 3 [gpadmin@mdw_ipv4 ~]$

fifthposition commented 3 years ago

Docs story created for first issue.

@edespino I'm not sure what Docs should do about the second issue (apparently missing validation?).

bala-cg commented 3 years ago

@fifthposition, almost all parameters the validation is missing while setting it via gpconfig, we logged a different issue(184) for this, you can ignore this point.