vmware-archive / vmware-vcenter

VMware vCenter Module
Other
87 stars 101 forks source link

use title_patterns and composite namevars instead of munging "name" #200

Closed crayfishx closed 8 years ago

crayfishx commented 8 years ago

@maniacmurphy pointed out in #187 that the use of munging the name parameter into other parameters is not something that is recommended - The better way to achieve what the type is trying to do is to use composite namevars and title patterns to map them.... this PR adds some tests around this and uses title_patterns to handle the setting of host and vswitch from the resource title in a more supported way.

maniacmurphy commented 8 years ago

Awesome! Big thanks @crayfishx