vmware-clarity / core

Clarity is a scalable, accessible, customizable, open-source design system built with web components. Works with any JavaScript framework, created for enterprises, and designed to be inclusive.
https://clarity.design
MIT License
164 stars 42 forks source link

fix(icons): use the non-shade alias color for info status icons #225

Closed astorije-vmware closed 1 year ago

astorije-vmware commented 1 year ago

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

What is the current behavior?

The current info status icons are colored with the shade variant, which gives the icon a very low contrast in dark theme.

Screen Shot 2023-04-11 at 11 36 50 AM Screen Shot 2023-04-11 at 11 37 09 AM

This is particularly true for regular-sized icons (i.e. smaller than lg):

Screen Shot 2023-04-11 at 11 40 29 AM

Issue Number: N/A

What is the new behavior?

This change aligns the info icons more closely with, well, most everything else such as cds-buttons which are displayed using the non-shade version, as well as non-info icons. As you can tell below, the impact on light theme is negligible, but in dark theme the contrast seems much better:

Screen Shot 2023-04-11 at 11 37 59 AM Screen Shot 2023-04-11 at 11 38 11 AM

And on smaller icons:

Screen Shot 2023-04-11 at 11 42 30 AM

Does this PR introduce a breaking change?

vmwclabot commented 1 year ago

@astorije-vmware, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

github-actions[bot] commented 1 year ago

👋 @astorije-vmware,

Thank you,

🤖 Clarity Release Bot

github-actions[bot] commented 1 year ago

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.