Closed astorije closed 1 year ago
@astorije, VMware has rejected your signed contributor license agreement. The merge can not proceed until the agreement has been resigned. Click here to resign the agreement. Reject reason:
Please provide city, state (or province), and country of residence or mailing address.
👋 @astorije,
Thank you,
🤖 Clarity Release Bot
@astorije, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed.
@astorije, VMware has rejected your signed contributor license agreement. The merge can not proceed until the agreement has been resigned. Click here to resign the agreement. Reject reason:
Please provide a telephone number and full address. Please provide the name of the organization you are affiliated with or indicate none. Note: If you are a VMware employee please use your VMware email and you are then not required to execute the VMware CLA.
@astorije, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed.
@astorije, VMware has approved your signed contributor license agreement.
@kevinbuhmann and @colinreedmiller, friendly ping? :)
@kevinbuhmann and @colinreedmiller, friendly ping? :)
I posted in our internal Slack channel for someone on our design team to review this.
@kevinbuhmann and @colinreedmiller, friendly ping? :)
I posted in our internal Slack channel for someone on our design team to review this.
We need to complete the token mapping evaluation across the themes to determine what the design guidance will be. The current use of --cds-alias-status-warning is problematic in dark theme barely meets contrast and the suggested fails to leverage the change to yellow for warning status - the info status is correct.
Thanks all!
:tada: This PR is included in version 6.4.1 :tada:
The release is available on:
v6.4.1
Your semantic-release bot :package::rocket:
Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The current
info
status icons are colored with theshade
variant, which gives the icon a very low contrast in dark theme.This is particularly true for regular-sized icons (i.e. smaller than
lg
):Issue Number: N/A
What is the new behavior?
This change aligns the info icons more closely with, well, most everything else such as
cds-button
s which are displayed using the non-shade version, as well as non-info icons. As you can tell below, the impact on light theme is negligible, but in dark theme the contrast seems much better:And on smaller icons:
Does this PR introduce a breaking change?