vmware-clarity / core

Clarity is a scalable, accessible, customizable, open-source design system built with web components. Works with any JavaScript framework, created for enterprises, and designed to be inclusive.
https://clarity.design
MIT License
164 stars 42 forks source link

fix(textarea): add width, min-height, resize as custom css variables #235

Closed dtsanevmw closed 1 year ago

dtsanevmw commented 1 year ago

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

What is the current behavior?

Currently there are some css values that can't be changed outside and the textarea is not very flexible.

Issue Number: N/A

What is the new behavior?

Removed the "important" from these values and now if someone needs a change it can be achieved.

Does this PR introduce a breaking change?

Other information

github-actions[bot] commented 1 year ago

👋 @dtsanevmw,

Thank you,

🤖 Clarity Release Bot

dtsanevmw commented 1 year ago

I do not think we should merge this. The CSS Custom Properties are the mechanism by which Clarity Core components are intended to be customized, not directly overriding styles.

Yes, I agree. I exposed adding the other three css rules as variables.

github-actions[bot] commented 12 months ago

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.