Closed beaker1977 closed 1 year ago
Which icon component?
The cds-icon
component from @cds/core
?
I can see both on https://core.clarity.design/foundation/icons/shapes when I search for script
. Which version of the @cds/core
package are you using?
The clr-icon
component from@clr/icons
?
The @clr/icons
package is deprecated in favor of cds-icon
from the @cds/core
package.
I agree you can see the icons on that page. The problem becomes when you download the accompanying svg file. That is what is empty (see the files that I've attached). As for the version, I'm using
"@cds/core": "^6.4.2",
"@clr/angular": "^15.3.0",
"@clr/ui": "^15.3.0",
And yes I am using cds-icon component.
Ah, I see.
We need to audit https://github.com/vmware/clarity-assets/tree/master/icons for missing icons.
moved to vmware-clarity/ng-clarity#693.
What's the status of new icon files? They are still empty when I download them and this wasn't addressed in issue 693.
What's the status of new icon files? They are still empty when I download them and this wasn't addressed in issue 693.
I have just merged a fix to the website. It is deploying now. It will now generated the icon directly from the selected cds-icon
element instead of relying on the svg file existing in the assets repo.
Close but no cigar. A new svg file was generated but it renders the icon for Event, not Script-execute. If you look at the code in the svg file it matches the code in the Event svg file.
I get the correct svg when I download the script-execute
icon on https://core.clarity.design/foundation/icons/shapes/.
I am not sure what the code is for that screenshot, so I cannot diagnose it.
Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed issues after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.
The svg files for icons script-execute and script-schedule are empty.