search

vmware-clarity / core

Clarity is a scalable, accessible, customizable, open-source design system built with web components. Works with any JavaScript framework, created for enterprises, and designed to be inclusive.
https://clarity.design
MIT License
164 stars 42 forks source link

[pdfFileIcon] unclear where to import the pdf file icon from #241

Open cianmcgovern93 opened 1 year ago

cianmcgovern93 commented 1 year ago

To use the icon ...shape="pdf-file"... I noticed it had to be imported from import { pdfFileIcon } from "@cds/core/icon/shapes/pdf-file"; I would have assumed I would have been able to import it from "@cds/core/icon" like other icons.

The documents should be updated to clearly show where to import the pdf icon from or better still it would be great to be able to import the icon via the path "@cds/core/icon" like other icons.

This caused a bit of confusion for me yesterday and it would be great to rectify this.

abonhote commented 1 year ago

Hey @cianmcgovern93 - did you manage to sort this out? I'm struggling with the docs too, one small real life example with icons would help a lot.

kevinbuhmann commented 1 year ago

I think was fixed in vmware-clarity/core#240. Please check with the latest version of @cds/core.