Closed scothis closed 4 months ago
Attention: Patch coverage is 80.00000%
with 3 lines
in your changes are missing coverage. Please review.
Project coverage is 61.12%. Comparing base (
3180680
) to head (09436ab
).
Files | Patch % | Lines |
---|---|---|
testing/subreconciler.go | 0.00% | 2 Missing :warning: |
testing/webhook.go | 0.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
[question, non-blocking]: @scothis when you say
Custom equality func can be defined separately as needed.
are you meaning that there could potentially be a follow-up PR? I am asking because afaik there's currently no way to provide a custom equality func, or is there?
@mamachanko I was basing it on this comment https://github.com/vmware-labs/reconciler-runtime/issues/484#issuecomment-1958682986
@scothis this fix works! Thank you again for the quick turnaround!
@neowulf cool, I'll circle back to Max's feedback tomorrow.
Thank you @scothis !
@scothis, VMware has approved your signed contributor license agreement.
Using unexported fields in Kubernetes resources is not common, but does happen. Previously, these fields would cause cmp.Diff to panic. Now, we ignore the content of unexported fields when computing a diff. As the diff is for logging and test assertions this is relatively safe.
Semantic equality is used for detecting when a managed resource needs to be updated. Custom equality func can be defined separately as needed.
Refs #484