vmware-tanzu / helm-charts

Contains Helm charts for Kubernetes related open source tools
https://vmware-tanzu.github.io/helm-charts/
Apache License 2.0
254 stars 363 forks source link

change to upgrade job values #547

Open soumyapattnaik opened 9 months ago

soumyapattnaik commented 9 months ago

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

jenting commented 9 months ago

Why do we require to increase the memory limits?

soumyapattnaik commented 9 months ago

Why do we require to increase the memory limits?

Please refer to below PR by my team member who did it for azure backup. In some customer we observed that upgradejob were getting OOMKilled after the maintenance window, they only got mitigated after they increased the limits to 512

earlier PR- https://github.com/vmware-tanzu/helm-charts/pull/514

anshulahuja98 commented 9 months ago

@jenting can we uncomment https://github.com/vmware-tanzu/helm-charts/pull/524/files and bump up memory based on this PR. This number has worked well for us in downstream usage.

anshulahuja98 commented 9 months ago

CC @qiuming-best

qiuming-best commented 9 months ago

@jenting lint-test failed with checking the chart version, should we bump up the version? or could someone approve it directly?

As I've committed to this PR, I cannot approve it now.

jenting commented 9 months ago

@qiuming-best yez, the Chart version should upgrade as well.

anshulahuja98 commented 9 months ago

@qiuming-best what are your thoughts on uncommenting the values?

anshulahuja98 commented 9 months ago

For version bump I'll ask @soumyapattnaik

jenting commented 9 months ago

Please don't uncomment, user could overwrite the value by their own. The comment value is the suggestion, not the mandatory value.

anshulahuja98 commented 9 months ago

Alright sure Have pinged @soumyapattnaik to bump the chart version, we can approve post that and checkin.

soumyapattnaik commented 7 months ago

updated chart.yaml to 6.0.1

jenting commented 6 months ago

Could you please help bump the version?