vmware-tanzu / nsx-operator

Kubernetes Operator for managing NSX network resources
Other
13 stars 20 forks source link

Add error check in service_lb_controller #936

Open TaoZou1 opened 13 hours ago

TaoZou1 commented 13 hours ago

Add more error check in service_lb_controller

codecov-commenter commented 9 hours ago

Codecov Report

Attention: Patch coverage is 65.62500% with 11 lines in your changes missing coverage. Please review.

Project coverage is 73.39%. Comparing base (a3a6318) to head (d27cfa7). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/controllers/service/service_lb_controller.go 65.62% 9 Missing and 2 partials :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/vmware-tanzu/nsx-operator/pull/936/graphs/tree.svg?width=650&height=150&src=pr&token=R0Q6IGC2PC&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware-tanzu)](https://app.codecov.io/gh/vmware-tanzu/nsx-operator/pull/936?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware-tanzu) ```diff @@ Coverage Diff @@ ## main #936 +/- ## ========================================== - Coverage 73.41% 73.39% -0.02% ========================================== Files 109 109 Lines 15264 15284 +20 ========================================== + Hits 11206 11218 +12 - Misses 3307 3314 +7 - Partials 751 752 +1 ``` | [Flag](https://app.codecov.io/gh/vmware-tanzu/nsx-operator/pull/936/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware-tanzu) | Coverage Δ | | |---|---|---| | [unit-tests](https://app.codecov.io/gh/vmware-tanzu/nsx-operator/pull/936/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware-tanzu) | `73.39% <65.62%> (-0.02%)` | :arrow_down: | | [Files with missing lines](https://app.codecov.io/gh/vmware-tanzu/nsx-operator/pull/936?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware-tanzu) | Coverage Δ | | |---|---|---| | [pkg/controllers/service/service\_lb\_controller.go](https://app.codecov.io/gh/vmware-tanzu/nsx-operator/pull/936?src=pr&el=tree&filepath=pkg%2Fcontrollers%2Fservice%2Fservice_lb_controller.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware-tanzu#diff-cGtnL2NvbnRyb2xsZXJzL3NlcnZpY2Uvc2VydmljZV9sYl9jb250cm9sbGVyLmdv) | `60.18% <65.62%> (-5.78%)` | :arrow_down: | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/vmware-tanzu/nsx-operator/pull/936/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware-tanzu)