search

vmware-tanzu / tanzu-framework

Tanzu Framework provides a set of building blocks to build atop of the Tanzu platform and leverages Carvel packaging and plugins to provide users with a much stronger, more integrated experience than the loose coupling and stand-alone commands of the previous generation of tools.
Apache License 2.0
196 stars 193 forks source link

Ginko errors in test runs #941

Open stmcginnis opened 2 years ago

stmcginnis commented 2 years ago

Bug description

We are hitting deprecated behavior in the Ginko test framework. These errors are being emitted during test runs:

You're using deprecated Ginkgo functionality:
=============================================
Ginkgo 2.0 is under active development and will introduce (a small number of) breaking changes.
To learn more, view the migration guide at https://github.com/onsi/ginkgo/blob/v2/docs/MIGRATING_TO_V2.md
To comment, chime in at https://github.com/onsi/ginkgo/issues/711

  You are passing a Done channel to a test node to test asynchronous behavior.  This is deprecated in Ginkgo V2.  Your test will run synchronously and the timeout will be ignored.
  Learn more at: https://github.com/onsi/ginkgo/blob/v2/docs/MIGRATING_TO_V2.md#removed-async-testing
    /home/runner/work/tanzu-framework/tanzu-framework/addons/pkg/crdwait/suite_test.go:28
  You are using a custom reporter.  Support for custom reporters will likely be removed in V2.  Most users were using them to generate junit or teamcity reports and this functionality will be merged into the core reporter.  In addition, Ginkgo 2.0 will support emitting a JSON-formatted report that users can then manipulate to generate custom reports.

  If this change will be impactful to you please leave a comment on https://github.com/onsi/ginkgo/issues/711
  Learn more at: https://github.com/onsi/ginkgo/blob/v2/docs/MIGRATING_TO_V2.md#removed-custom-reporters

To silence deprecations that can be silenced set the following environment variable:
  ACK_GINKGO_DEPRECATIONS=1.16.2

An example can be seen here.

We should find where that is happening and make sure our tests will continue to function once this deprecated behavior is removed.

Affected product area (please put an X in all that apply)

Expected behavior

Tests run with no deprecation warnings issued.

danniel1205 commented 2 years ago

We might want to follow https://github.com/onsi/ginkgo/blob/ver2/docs/MIGRATING_TO_V2.md#removed-custom-reporters once we bump ginkgo to v2. For now, I guess it is a good idea to add ACK_GINKGO_DEPRECATIONS to silence the deprecation message.

danniel1205 commented 2 years ago

As of today, Ginkgo v2 has not been release yet, only RC is available. We could monitor https://github.com/onsi/ginkgo/releases and bump to v2 once it is out.

blc1996 commented 2 years ago

The Ginkgo v2 is not released yet, still pending.

vijaykatam commented 2 years ago

Removing kind/bug label because these are deprecation warnings to watch when migrating to Ginkgo v2 and don't actually result in test failure.

codegold79 commented 2 years ago

Ginkgo v2.1.1 was released late last month (January 2022).

Should the fix for this issue be to upgrade to Ginkgo v2.1.1?