Login view fails to open in RemoteDebugView after being closed from DeploymentDialog

vmware-tanzu / tanzu-toolkit-for-visual-studio

Apache License 2.0

10 stars 3 forks source link

Login view fails to open in RemoteDebugView after being closed from DeploymentDialog #370

Closed andrew-woosnam closed 2 years ago

andrew-woosnam commented 2 years ago

The login view opens as expected for most scenarios, but this very particular sequence of clicks causes an error which prevents the login view from being able open at all.

To reproduce:

right click .net project in solution explorer
click "Push to TAS"
click log in button in DeploymentDialog
click 'Cancel' to close login view
click 'Cancel' to close DeploymentDialog
right click .net project in solution explorer
click "Remote Debug"
click log in button in Remote Debug view

andrew-woosnam commented 2 years ago

For some reason I don't understand, calling Close() on the DeploymentDialogView ALSO closes the LoginView?? (this happens implicitly, seemingly as a decision of WPF; none of our business logic is asking for this to happen)

This explains why this bug only occurs when closing the DeploymentDialog; the RemoteDebugView, by contrast, is "closed" using Hide()