vmware-tanzu / velero

Backup and migrate Kubernetes applications and their persistent volumes
https://velero.io
Apache License 2.0
8.79k stars 1.41k forks source link

CSI plugin should support backup migrated PVCs #6137

Closed blackpiglet closed 1 year ago

blackpiglet commented 1 year ago

Describe the problem/challenge you have

CSI plugin judges a PVC whether is a CSI one by it has a CSI section in SPEC.

https://github.com/vmware-tanzu/velero-plugin-for-csi/blob/5ee80604e580295e9afea51fcf73765b070a9ca7/internal/backup/pvc_action.go#L82-L85

This will rule out the migrated PVC.

Describe the solution you'd like

Need a new way to also handle the migrated PVCs.

Anything else you would like to add:

Environment:

Vote on this issue!

This is an invitation to the Velero community to vote on issues, you can see the project's top voted issues listed here.
Use the "reaction smiley face" up to the right of this comment to vote.

anshulahuja98 commented 1 year ago

I am not sure if migrated PVCs can be snapshotted by the external snapshotter. it is not fully clear to me what this issue is meant to tackle.

blackpiglet commented 1 year ago

I just found this issue. You are right. Even Velero CSI plugin supports it, but the external-snapshotter doesn't support it too.

anshulahuja98 commented 1 year ago

yeah thanks for updating the thread with the issue link It is a major limitation of CSI for in tree.

anshulahuja98 commented 1 year ago

We can delink the 1.12 milestone