nmctl: Fixed DHCP set/reset for IPV4.

vmware / network-config-manager

Network configuration manager is utility for easily configuring networking on a linux system

Other

34 stars 10 forks source link

Closed ntsbtz closed 5 months ago

ntsbtz commented 5 months ago

Issue: nmctl set-ipv4 dhcp no is also reset dhcp for ipv6 like DHCP=yes convert to DHCP=no instead of DHCP=ipv6

Also while setting nmctl set-ipv4 dhcp yes it convert DHCP=yes to DHCP=ipv4.

Fix: Check for existing DHCP=mode, based on that only tune the DHCP configuration for ipv4 without affecting DHCP IPV6 status.

ssahani commented 5 months ago

Is not these API are deprecated? Please use the set-dymamic

ssahani commented 5 months ago

Commit message nmctl: Fixed DHCP set/reset for IPV3. ? -> nmctl: Fixed DHCP set/reset for IPv4.

ntsbtz commented 5 months ago

Is not these API are deprecated? Please use the set-dymamic

Yes but this API is in use now so required to fix.

ntsbtz commented 5 months ago

Please Add test a test

Done with all other review comments.