vmware / network-config-manager

Network configuration manager is utility for easily configuring networking on a linux system
Other
34 stars 10 forks source link

network-config-manager: Fix incorrect IPv6 config source #710

Closed ntsbtz closed 22 hours ago

ntsbtz commented 2 months ago

Issue - nmctl status -j is showing ConfigSource as foreign for all kind of address like static, dynamic and foreign.

Now on existing flow to get a link address info nmctl get the info from dbus and parse the info similar for address as well. While parsing the address from json object to ip, prefix length is not appended to address. Hence ip matching with address always failing for IPv6, cause of this ConfigSource always set to foreign regardless of address is static or dynamic.

Fix - Fixed in json_array_to_ip parsing to take care of prefix value as well while returning the ip address after parsing the json object.

ntsbtz commented 22 hours ago

This issue is already taken care in below pull request, Hence closing this. https://github.com/vmware/network-config-manager/pull/711